Skip to content

Add formal constant for voxel extension#1329

Open
j9liu wants to merge 1 commit intomainfrom
voxel-mode
Open

Add formal constant for voxel extension#1329
j9liu wants to merge 1 commit intomainfrom
voxel-mode

Conversation

@j9liu
Copy link
Contributor

@j9liu j9liu commented Mar 19, 2026

Description

Depends on #1188, so merge that first.

Supports CesiumGS/cesium-unreal#1685. Per PR feedback, the special mode constant used by this extension should be formally defined in cesium-native for use in a runtime.

Author checklist

  • I have submitted a Contributor License Agreement (only needed once).
  • I have done a full self-review of my code.
  • I have updated CHANGES.md with a short summary of my change (for user-facing changes).
  • [ ] I have added or updated unit tests to ensure consistent code coverage as necessary.
  • I have updated the documentation as necessary.

Testing plan

N/A, not really testable.

Reviewer checklist

Thank you for taking the time to review this PR. By approving a PR you are taking as much responsibility for these changes as the author.

As you review, please go through the checklist below:

  • Review and run all parts of the test plan on this branch and verify it matches expectations.
    • If the issue is a bug please make sure you can reproduce the bug in the main branch and then checkout this branch to make sure it actually solved the issue.
  • Review the code and make sure you do not have any remaining questions or concerns. You should understand the code change and the chosen approach. If you are not confident or have doubts about the code, please do not hesitate to ask questions.
  • Review the unit tests and make sure there are no missing tests or edge cases.
  • Review documentation changes and updates to CHANGES.md to make sure they accurately cover the work in this PR.
  • Verify that the Contributor License Agreement has been submitted, if needed.

@j9liu j9liu changed the title Add formal constant to voxel extension Add formal constant for voxel extension Mar 19, 2026
@j9liu j9liu added this to the April 2026 Release milestone Mar 20, 2026
@j9liu j9liu requested a review from azrogers March 20, 2026 15:19
@david-lively david-lively self-assigned this Mar 20, 2026
@j9liu j9liu requested review from david-lively and removed request for azrogers March 20, 2026 15:33
Copy link
Contributor

@david-lively david-lively left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Waiting on #1188 to merge before merging this one.

Base automatically changed from tile-sse to main March 24, 2026 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants